search

thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:CommentedOutCodeLine, squid:S2131, squid:S1125, squid:S1155, squid:S1854, squid:S00122, squid:S1481, squid:S1192 #84

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S2131 - Primitives should not be boxed just for "String" conversion. squid:S1125 - Literal boolean values should not be used in condition expressions. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1854 - Dead stores should be removed. squid:S00122 - Statements should be on separate lines. squid:S1481 - Unused local variables should be removed. squid:S1192 - String literals should not be duplicated. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S2131 https://dev.eclipse.org/sonar/rules/show/squid:S1125 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1192 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for this