Closed georgekankava closed 8 years ago
This pull request is focused on resolving occurrences of Sonar rules squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S00122 - Statements should be on separate lines. squid:S00117 - Local variable and method parameter names should comply with a naming convention. squid:S1854 - Dead stores should be removed. squid:S2131 - Primitives should not be boxed just for "String" conversion. squid:S1905 - Redundant casts should not be used. squid:S1066 - Collapsible "if" statements should be merged. squid:S1125 - Literal boolean values should not be used in condition expressions. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2583 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S00117 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S2131 https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S1125 Please let me know if you have any questions. George Kankava
Thanks for your help
thothbot
commented
8 years ago thothbot
commented
8 years ago
This pull request is focused on resolving occurrences of Sonar rules squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE". squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S00122 - Statements should be on separate lines. squid:S00117 - Local variable and method parameter names should comply with a naming convention. squid:S1854 - Dead stores should be removed. squid:S2131 - Primitives should not be boxed just for "String" conversion. squid:S1905 - Redundant casts should not be used. squid:S1066 - Collapsible "if" statements should be merged. squid:S1125 - Literal boolean values should not be used in condition expressions. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2583 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S00117 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S2131 https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S1125 Please let me know if you have any questions. George Kankava