thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S2786, squid:S00116, squid:S1068, squid:CommentedOutCodeLine, squid:S1213, squid:S1149, squid:S1854 #94

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S2786 - Nested "enum"s should not be declared static. squid:S00116 - Field names should comply with a naming convention. squid:S1068 - Unused private fields should be removed. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used. squid:S1854 - Dead stores should be removed. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2786 https://dev.eclipse.org/sonar/rules/show/squid:S00116 https://dev.eclipse.org/sonar/rules/show/squid:S1068 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1213 https://dev.eclipse.org/sonar/rules/show/squid:S1149 https://dev.eclipse.org/sonar/rules/show/squid:S1854 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your help