Closed thothix closed 18 hours ago
You need to use another variable instead of %{name}, maybe you can create: %{metadata_name} = "org.guayadeque.guayadeque" and use:
%{_datadir}/applications/%{metadata_name}.desktop %{_datadir}/icons/hicolor/64x64/apps/%{name}.png %{_datadir}/metainfo/%{metadata_name}.metainfo.xml
Hi Tiago
I only found that some translations are missing in the org.guayadeque.guayadeque.desktop : in Guayadeque 0.6.0 it was
Name[en_US]=Guayadeque Music Player Name[fr]=Lecteur de musique Guayadeque Name[lt]=Guayadeque muzikos grotuvas Name[pt_BR]=Guayadeque Reprodutor de Música Comment=Play and organize your music, listen to radios, podcasts and more... Comment[fr]=Jouez et organisez votre musique, écouter des radios, des balados, et plus encore... Comment[lt]=Groti ir tvarkyti savo muziką, klausytis radijų, tinklalaidžių ir daugiau... Comment[pt_BR]=Reproduza e organize suas músicas, escute rádios, podcasts e mais...
NB for the French comment we don't use anymore "balados" but the English "podcast" I added an italian and a greek translation Since it is not yet tagged I suggest it may be now for Guayadeque 0.6.1
Name=Guayadeque Music Player Name[el]=Συσκευή αναπαραγωγής μουσικής Guayadeque Name[fr]=Lecteur de musique Guayadeque Name[it]=Lettore musicale Guayadeque Name[lt]=Guayadeque muzikos grotuvas Name[pt_BR]=Guayadeque Reprodutor de Música Comment=Play and organize your music, listen to radios, podcasts and more... Comment[el]=Ακούστε και οργανώστε τη μουσική σας, ακούστε ραδιόφωνα, podcasts και πολλά άλλα... Comment[fr]=Écoutez et organisez votre musique, écoutez des radios, des podcasts, et plus encore... Comment[it]=Riproduci e organizza la tua musica, ascolta radio, podcast e altro ancora... Comment[lt]=Groti ir tvarkyti savo muziką, klausytis radijų, tinklalaidžių ir daugiau... Comment[pt_BR]=Reproduza e organize suas músicas, escute rádios, podcasts e mais...
Post Scriptum I built it (with some little changes in the spec file) I tested it (as a fresh install or as an update using the previous /home/myusername/.guayadeque) Everything works perfectly
Hi Tiago
I only found that some translations are missing in the org.guayadeque.guayadeque.desktop : in Guayadeque 0.6.0 it was
Name[en_US]=Guayadeque Music Player Name[fr]=Lecteur de musique Guayadeque Name[lt]=Guayadeque muzikos grotuvas Name[pt_BR]=Guayadeque Reprodutor de Música Comment=Play and organize your music, listen to radios, podcasts and more... Comment[fr]=Jouez et organisez votre musique, écouter des radios, des balados, et plus encore... Comment[lt]=Groti ir tvarkyti savo muziką, klausytis radijų, tinklalaidžių ir daugiau... Comment[pt_BR]=Reproduza e organize suas músicas, escute rádios, podcasts e mais...
NB for the French comment we don't use anymore "balados" but the English "podcast" I added an italian and a greek translation Since it is not yet tagged I suggest it may be now for Guayadeque 0.6.1
Name=Guayadeque Music Player Name[el]=Συσκευή αναπαραγωγής μουσικής Guayadeque Name[fr]=Lecteur de musique Guayadeque Name[it]=Lettore musicale Guayadeque Name[lt]=Guayadeque muzikos grotuvas Name[pt_BR]=Guayadeque Reprodutor de Música Comment=Play and organize your music, listen to radios, podcasts and more... Comment[el]=Ακούστε και οργανώστε τη μουσική σας, ακούστε ραδιόφωνα, podcasts και πολλά άλλα... Comment[fr]=Écoutez et organisez votre musique, écoutez des radios, des podcasts, et plus encore... Comment[it]=Riproduci e organizza la tua musica, ascolta radio, podcast e altro ancora... Comment[lt]=Groti ir tvarkyti savo muziką, klausytis radijų, tinklalaidžių ir daugiau... Comment[pt_BR]=Reproduza e organize suas músicas, escute rádios, podcasts e mais...
.desktop updated. Thanks!
v0.6.1 released!
There's only a few and small changes in the code but I released it anyway because the metadata changes are required for Debian and Fedora packaging.
Hi Tiago guayadeque-0.6.1 downloaded, built (with the modified spec file to install icon desktop and metainfo), installed and tested -1) as a fresh install where I can see the default setting of lyrics (see https://github.com/thothix/guayadeque/issues/4#issuecomment-2471362499 and my opinion about this setting) -2) as an update using my previous /home/myusername/.guayadeque Everything is OK
the only problem is that the latest release to download is linked to the commit 42ac2a4 and not to the 9f06f00 and doesn't contain the improved desktop file (it's only a cosmetic problem ;-) )
I reissued the release
OK now it's the right commit I rebuild with it It's fine : desktop file corrected It works well
... I can see the default setting of lyrics (see #4 (comment) and my opinion about this setting)
About your #4 comment, I'm not sure about setting the target embedded option by default. I would prefer to let the user choose the destination. The user may want that the application don't modify your files, for example.
... I can see the default setting of lyrics (see #4 (comment) and my opinion about this setting)
About your #4 comment, I'm not sure about setting the target embedded option by default. I would prefer to let the user choose the destination. The user may want that the application don't modify your files, for example.
I agree for the second target (destination -> embedded) not to be marked if a user don't want to modify his files
But the first target (source = embedded) allows to display the already embedded lyrics without having to search them on internet (a fortiori if you have no connection... ) this doesn't prevent to search when there's nothing embedded
Right, I'll update the (source = embedded) default for the next release. Thanks.
here is the extended entry for german [de] for org.guayadeque.guayadeque.desktop
Name=Guayadeque Music Player
Name[de]=Guayadeque-Musikplayer
Name[el]=Συσκευή αναπαραγωγής μουσικής Guayadeque
Name[fr]=Lecteur de musique Guayadeque
Name[it]=Lettore musicale Guayadeque
Name[lt]=Guayadeque muzikos grotuvas
Name[pt_BR]=Guayadeque Reprodutor de Música
Comment=Play and organize your music, listen to radios, podcasts and more...
Comment[de]=Hören und organisieren Sie Ihre Musik, hören Sie Radiosender, Podcasts und vieles mehr...
Comment[el]=Ακούστε και οργανώστε τη μουσική σας, ακούστε ραδιόφωνα, podcasts και πολλά άλλα...
Comment[fr]=Écoutez et organisez votre musique, écoutez des radios, des podcasts, et plus encore...
Comment[it]=Riproduci e organizza la tua musica, ascolta radio, podcast e altro ancora...
Comment[lt]=Groti ir tvarkyti savo muziką, klausytis radijų, tinklalaidžių ir daugiau...
Comment[pt_BR]=Reproduza e organize suas músicas, escute rádios, podcasts e mais...
Hi @filochard
There's some changes in the config files so you'll need to do some adjustments in your .spec file.
The changes are related to this:
install(FILES defconfig/guayadeque.png DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/icons/hicolor/64x64/apps/) install(FILES defconfig/org.guayadeque.guayadeque.desktop DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/applications) install(FILES defconfig/org.guayadeque.guayadeque.metainfo.xml DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/metainfo)
Now they have different names and/or target locations.