search

thought-driven / bummr

Update your gems in separate commits. Identify any that fail your build.
MIT License
234 stars 23 forks source link

Make bisect work with old git 1.9.1 #28

Closed map7 closed 8 years ago

map7 commented 8 years ago

I found that git version 1.9.1 under Debian wheezy does not like combining the bad & good commands into the bisect start command like so; git bisect start head master. It starts bisect correctly but it doesn't set the bad & good points.

lpender commented 8 years ago

Thanks for the PR @map7! You are going to need to update the spec/lib/bisecter_spec.rb file as well.

I think just changing:

    allow(bisecter).to receive(:system).with("git bisect start head master")

to 

    allow(bisecter).to receive(:system)

should do it.

You can test it locally by running rake. Thanks

map7 commented 8 years ago

I've updated that spec file.