search

thought-driven / bummr

Update your gems in separate commits. Identify any that fail your build.
MIT License
234 stars 23 forks source link

Consider using rainbow instead of colorize due to GPL license restriction #32

Closed monfresh closed 7 years ago

monfresh commented 8 years ago

Hi @lpender, I started looking into license compliance for some projects I'm working on, and we can't use a gem that uses the GPL license without our project changing its license to GPL, which we don't want to do. The colorize gem uses the GPL-2 license, and the owner of the project doesn't seem to want to change it. See this issue: https://github.com/fazibear/colorize/issues/47

In that thread, someone recommended the rainbow gem, which seems like a good alternative. Would you consider switching to rainbow?

I noticed that you use the MIT license for bummr, but because you use colorize, you would need to convert to a GPL-2 license, which is probably not what you want.

lpender commented 8 years ago

Hey there.

Would you like to open a pull request for the changes you mentioned?

Thanks Lee On Wed, Jun 29, 2016 at 9:10 PM Moncef Belyamani notifications@github.com wrote:

Hi @lpender https://github.com/lpender, I started looking into license compliance for some projects I'm working on, and we can't use a gem that uses the GPL license without our project changing its license to GPL, which we don't want to do. The colorize gem uses the GPL-2 license, and the owner of the project doesn't seem to want to change it. See this issue: fazibear/colorize#47 https://github.com/fazibear/colorize/issues/47

In that thread, someone recommended the rainbow https://github.com/sickill/rainbow gem, which seems like a good alternative. Would you consider switching to rainbow?

I noticed that you use the MIT license for bummr, but because you use colorize, you would need to convert to a GPL-2 license, which is probably not what you want.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lpender/bummr/issues/32, or mute the thread https://github.com/notifications/unsubscribe/ABV2WqFcidxmpQVO7UQu6TIbX6F50LPwks5qQxdngaJpZM4JBtrW .

monfresh commented 8 years ago

Sure, I can give it a shot, but it will probably take me more time than you since I haven't used colorize or rainbow before. Also, is the dependency on colorize covered in the test suite? How would I know whether or not the switch from colorize to rainbow didn't break anything?

monfresh commented 8 years ago

Do I just need to look for methods like .red, .green, .yellow and check the output manually?

connorshea commented 8 years ago

@monfresh this might help as an example: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4425

skull-squadron commented 7 years ago

Just ran into this myself. Awesome license checker tool: gem install license_finder github

lpender commented 7 years ago

Fixed in 0.1.6. Thx

monfresh commented 7 years ago

Thanks!