search

thought-machine / please

High-performance extensible build system for reproducible multi-language builds.
https://please.build
Apache License 2.0
2.47k stars 206 forks source link

Mixup between expected and actual checksum #3228

Open tm-jdelapuente opened 2 months ago

tm-jdelapuente commented 2 months ago

After upgrading Please to 17.10.1 in .plzconfig with the hash of 17.9.0 (87724be4995cc0385b18eea05feb23c8672ab9817bd484401f2d1053e1117325) I ran and got

$ plz update --force
17:17:09.161 CRITICAL: Failed to download Please: Invalid checksum of downloaded file, was f5436a2f265f7cf905f384e74db9453bc9d012078273136c8c1452bff2ddb85e, expected 87724be4995cc0385b18eea05feb23c8672ab9817bd484401f2d1053e1117325

Problem: the hashes are the other way around - the expected is the actual and vice versa

toastwaffle commented 2 months ago

I think the behaviour is correct - according to the config we expecting the hash to be 87724b..., but when we downloaded Please the hash we got for the download was f5436a...

You could make the message more explicit, along the lines of downloaded file had hash ..., but hash expected in .plzconfig is ...