WIP: Fix Terraform for macos

thought-machine / pleasings

Addons & new build rules for Please

Apache License 2.0

98 stars 39 forks source link

WIP: Fix Terraform for macos #79

Closed mvgijssel closed 3 years ago

mvgijssel commented 3 years ago

The version of bash that comes with Macos 11.4 is ancient, 3.2, there I've installed a newer version using Homebrew which is available in my path, therefore changes the shebangs to use /usr/bin/env to locate the newer bash version.

Also updated the find method when searching for a binary in a Terraform provider to return the first executable file. This helps if the provider archive also contains other files like a README.

VJftw commented 3 years ago

Hi @mvgijssel !

Sorry, I've only just come across your PR now. I'll patch your changes into my rewrite (#86) and add you as a co-author for that patch 🙂

Thanks for this 💯

VJftw commented 3 years ago

Hi again! I've merged #86 so this should be working for you now :) thanks again for your patches! Please let us know if it's still not working as you'd expect

mvgijssel commented 3 years ago

Thanks for picking this up! Will let you know if I run into any problems :)