search

thoughtbot / Argo

Functional JSON parsing library for Swift
https://thoughtbot.com
MIT License
3.49k stars 198 forks source link

Fix tests for Swift 4 #467

Closed gfontenot closed 7 years ago

gfontenot commented 7 years ago

This updates the test suite for Swift 4 (basically just disambiguating Argo.Decodable from Swift.Decodable) and updates the test suite/package definition so that we can run the tests using swift test.

Note that this also removes support for running the tests from Xcode. See 422be95 for the reasoning behind this change.

gfontenot commented 7 years ago

CI will fail because we're explicitly telling it to fail.

jshier commented 7 years ago

IMO it's premature to remove the ability to run tests through Xcode. Until SPM is actually integrated into Xcode, contributors will have to make their edits in Xcode and then run the command line tool to run their tests, losing all of the IDE integrations provided for testing. Your theory about eventually dropping support for CocoaPods/Carthage may turn out to be true but is likely at least a year away, especially given the rate at which SPM is working on their Xcode integration. I'd suggest keeping the Xcode tests and updating the CI integration to do the multiple testing channels so any friction is there and not on the developer.

gfontenot commented 7 years ago

Been thinking about this PR a lot, and haven't been sure what to do with it. I'm moving the SPM stuff into a new branch (gf-spm-all-in) because like @jshier said, it's probably a bit premature to push everything in that direction. For now, I'm going to refocus this PR on fixing the tests for Swift 4, which will let us move forward with Swift 4 related renaming and breaking changes.

gfontenot commented 7 years ago

This was merged into master, not just closed. I forgot that I had a separate Swift 4 branch going.