thoughtbot / Swish

Nothing but Net(working)
MIT License
363 stars 39 forks source link

Fix building Swish 2.0 for Xcode 9.3 #119

Closed gfontenot closed 6 years ago

gfontenot commented 6 years ago

Xcode 9.3 brings along Swift 3.3, which has a couple slightly different behaviors that need to be special cased. Our current release (3.0+) of Swish handles these changes already, but some users are unable to upgrade right now, and we shouldn't make their lives more difficult.

This adds the fixes for Swift 3.3 without breaking compatibility for Swift 3.2 users.

I'm opening this PR for visibility but I'm going to delete the 2.0.3 branch as soon as I have a 2.0.3 release tagged.

Fixes #118