Swift 3.0 - Githubissues

thoughtbot / Swish

Nothing but Net(working)

MIT License

363 stars 39 forks source link

Swift 3.0 #95

Closed jakecraige closed 7 years ago

jakecraige commented 8 years ago

Built off @sharplet's open PR for 2.3 support

Do the minimum set of changes to support Swift 3.

There are other improvements we can make like:

using Any instead of AnyObject (JSONSerialization returns this now)
Adopt a more Swify API by not ignoring so many first args.

Open question(s):

Now that we have URLRequest, should we still support NSURLRequest and NSMutableURLRequest?

Eke commented 8 years ago

Hello, any updates on this PR?

jakecraige commented 8 years ago

@Eke We need to wait for #92 before merging this, but in the meantime you should be able to reference this branch swift-3.0 in your dependency manager to use this version

Eke commented 8 years ago

@jakecraige Thanks for info !

Eke commented 7 years ago

Hello, can you please update podspec dependencies for Argo and Result ?

ren commented 7 years ago

Hey folks, any update on this getting merged? Is there any work which could be contributed to this PR to get it closer to ready?

sharplet commented 7 years ago

@jakecraige @tonyd256 I've pushed a few more commits removing some unnecessary casts and updating our error handling to use the new LocalizedError and CustomNSError protocols. I think this should be about ready to merge!

jakecraige commented 7 years ago

👍 (can't approve through review since GH says this is "my" PR)