Possible to be subscribe to multiple channels

thoughtbot / Tropos

Weather and Forecasts for Humans

troposweather.com

MIT License

1.51k stars 201 forks source link

Possible to be subscribe to multiple channels #188

Closed klaaspieter closed 6 years ago

klaaspieter commented 8 years ago

The unsubscribe logic doesn't handle failure. If unsubscribing fails that device will not likely ever be unsubscribed. This means that device will continue receiving push notification for a previous time zone.

A potential fix, that doesn't require complicated retry logic, is to keep a list of time zones to unsubscribe from in NSUserDefaults and on every app launch attempt to unsubscribe again.

klaaspieter commented 8 years ago

I'm also wondering if there is a RAC solution to the retry problem? @sharplet?

sharplet commented 8 years ago

The short answer is yes, RAC does have good support for retry logic. The basics:

Objective-C:
- -retry:
- Or the more general -catch:
Swift:
- retry(_:)
- Or the more general flatMapError(_:)

I've used retry and catch in the past to implement an exponential backoff strategy.

sharplet commented 6 years ago

We've decided to back out push notifications functionality for now (#204).