thoughtbot / appraisal

A Ruby library for testing your library against different versions of dependencies.
https://thoughtbot.com
MIT License
1.25k stars 107 forks source link

Allow passing through of the full-index option. #137

Closed nickcharlton closed 6 years ago

nickcharlton commented 6 years ago

Bundler provides an option to fetch the full RubyGems index. This is useful in the case of really old dependencies (like Rails 3 in 2018) which still work, but are not returned normally. This allows passing that through to bundle install.

nickcharlton commented 6 years ago

This PR has inadvertently made me aware of a syntax issue meaning that the tests aren't running properly. Locally, the following line passes:

expect(output).to include
  'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=2'

But this doesn't:

expect(output).to include(
  'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=2'
)