thoughtbot / appraisal

A Ruby library for testing your library against different versions of dependencies.
https://thoughtbot.com
MIT License
1.25k stars 107 forks source link

git_source substitution doesn't work with nested groups #159

Closed BrianHawley closed 4 years ago

BrianHawley commented 4 years ago

If you declare a git_source at the top level of your Gemfile or a spec in Appraisals, it will substitute the gem source in gem declarations. If you want to use those gem sources in nested groups declared with group, platforms, platform, source, git, or path, the git_source declarations from the top level aren't inherited, so they don't work like they do with bundler.

Fortunately, in BundlerDSL there's a protected git_sources writer, and all the groups are also declared in that file. It should be easy enough to assign all of the group objects to a copy of the git_sources. That would make the substitutions work.