Open marcotc opened 3 years ago
In your local setup, have you switched git to use main
in the init.defaultBranch
configuration?
If I restore this value to master
, the tests pass but with main
two are failing. Could you try the same and see if you get the same outcome?
Oh! I think I understand the problem properly now.
I was previously running 2.2.4, and seeing failures around this test, too, which confused me. I upgraded bundler
to 2.2.24 which resolved the Git problem I mentioned previously (there's a small change we can make here to avoid a lot of hint: ...
warnings).
In the test, we're just running bundle install --local
by shelling out to it, so I think this is a problem upstream. I'll open an issue there as I can't see anything wrong with our setup here.
While implementing #184, I noticed that
appraisal
tests (invokingrake
in this repository) were failing.At first they were failing with the issue addressed by #184, but after fixing that there's still one more test failing:
This errors happens only with newer versions of bundler.
After bisecting the bundler changes, I found that https://github.com/rubygems/rubygems/commit/d8b59a1777ccbd548b14d46aab19e47df83f0676 introduces the behaviour makes this test fail (which was released with bundler 2.2.14).
It seems like
bundle install --local
wants to contactother-rubygems.org
, which doesn't seem right. When using a version of bundler from before https://github.com/rubygems/rubygems/commit/d8b59a1777ccbd548b14d46aab19e47df83f0676, it does not try to contact the remote.I wasn't able to decipher what part of https://github.com/rubygems/rubygems/commit/d8b59a1777ccbd548b14d46aab19e47df83f0676 is the culprit, or if the issue is in appraisal or in bundler itself. I'm opening the issue here as this is manifested in one of the tests in the repository.