Fix #216, extra newline with customize_gemfiles

thoughtbot / appraisal

A Ruby library for testing your library against different versions of dependencies.

https://thoughtbot.com

MIT License

1.25k stars 107 forks source link

Fix #216, extra newline with customize_gemfiles #222

Closed joe-sharp closed 3 months ago

joe-sharp commented 4 months ago

On line 67 we join with two newlines, which will create an extra newline with how we recommend people use the Gemfile customization feature. This PR chomps the final newline to prevent that extra empty line described in issue #216

joe-sharp commented 4 months ago

@nickcharlton this is ready for review but we may want to just proceed with #223 since it has this commit and adds a spec. Happy to proceed however works best for you.

nickcharlton commented 3 months ago

Thanks! I think this is worth merging in first to keep them separate, we can bring in the spec in #223.