search

thoughtbot / appraisal

A Ruby library for testing your library against different versions of dependencies.
https://thoughtbot.com
MIT License
1.25k stars 107 forks source link

Add gemfile variables #223

Closed joe-sharp closed 1 month ago

joe-sharp commented 4 months ago

Raised in https://github.com/thoughtbot/appraisal/pull/191#issuecomment-1248935068, it seems desirable to be able to use variables in customize_gemfiles so that custom instructions can be provided. I have added the most likely used options, but I am open to additional ideas.

I also wanted to rewrite the specs to make them a bit easier to troubleshoot if they fail. I added a spec to cover the issue fixed in #222 and coverage for the new variables feature added here.

joe-sharp commented 4 months ago

This PR contains the commit from https://github.com/thoughtbot/appraisal/pull/222 but is otherwise ready for review

nickcharlton commented 3 months ago

Nice! Thanks for doing this. Could you add a line to the README mentioning it?

joe-sharp commented 3 months ago

@nickcharlton , done and I added a few more useful variables as well. All documented and covered by specs! 😁

joe-sharp commented 2 months ago

@nickcharlton I believe this is ready to merge. Thanks!