thoughtbot / art_vandelay

Art Vandelay is an importer/exporter for Rails 6.0 and higher.
MIT License
73 stars 4 forks source link

Specs are failing due to change in apostrophe #20

Closed littleforest closed 1 year ago

littleforest commented 1 year ago

Rails main has changed the default apostrophe character, so some tests are now failing.

Not sure the best way to make this change -- is it okay to put a conditional in the test to check what version of Rails is being run?

Failure:
ArtVandelayTest::Import#test_returns_results [/home/runner/work/art_vandelay/art_vandelay/test/art_vandelay_test.rb:449]:
--- expected
+++ actual
@@ -1 +1 @@
-[{:row=>["invalid@example.com", nil], :errors=>{:***"can't be blank"]}}]
+[{:row=>["invalid@example.com", nil], :errors=>{:***"can’t be blank"]}}]
stevepolitodesign commented 1 year ago

Closed by #21