thoughtbot / belt

Belt is a CLI for starting a new React Native Expo app and will even keep your pants secure as you continue development.
MIT License
131 stars 3 forks source link

Add React Navigation support #22

Closed rakeshpetit closed 11 months ago

rakeshpetit commented 1 year ago

This PR is an attempt to add React Navigation and a stack navigator to the scaffolded Expo app.

Todo

Success flow

image

rakeshpetit commented 11 months ago

@stevehanson - I updated the tests and everything passes fine on the generated app but thoughtbelt still seems to complain on the CI. Hope to pair and resolve this.

rakeshpetit commented 11 months ago

@stevehanson - I updated the tests and everything passes fine on the generated app but thoughtbelt still seems to complain on the CI. Hope to pair and resolve this.

I think I've fixed that in the latest update.

rakeshpetit commented 11 months ago

Things work well on my local machine but fails on the CI 😞

codeofdiego commented 11 months ago

@rakeshpetit Can you try adding the file name "./**/*.tsx" to "include": ["./**/*.ts", "./**/*.tsx"], in tsconfig.json?

rakeshpetit commented 11 months ago

@rakeshpetit Can you try adding the file name "./**/*.tsx" to "include": ["./**/*.ts", "./**/*.tsx"], in tsconfig.json?

Adding __tests__ to tsconfig solved the problem in commit

stevehanson commented 11 months ago

Taking a look at this now to see what's left to get it to the finish line.