Add React Query command

thoughtbot / belt

Belt is a CLI for starting a new React Native Expo app and will even keep your pants secure as you continue development.

MIT License

131 stars 3 forks source link

Add React Query command #26

Closed stevehanson closed 6 months ago

stevehanson commented 11 months ago

This follows the template that we previously coded in react-native-templates.

Installs React Query
Installs testing/mocking utility, MSW
Creates a mocking and testing strategy
Adds an example API call and mock and test

For now, the "create" command automatically uses React Query, but we will likely decide to prompt the user if they'd like to use this or Apollo (for GraphQL) in the future.

rakeshpetit commented 9 months ago

I rebased this branch and force pushed.

rakeshpetit commented 9 months ago

One problem I encountered was the test suite in the created expo app did not exit gracefully. This could be the reason behind CI failure.

stevehanson commented 8 months ago

This command should probably ask the user if they want to use React Query and not automatically install it.

codeofdiego commented 8 months ago

Hi folks, I'm working on this PR as part of Space Station 🛰️

codeofdiego commented 8 months ago

This command should probably ask the user if they want to use React Query and not automatically install it.

@stevehanson Do you mean as part of the standard create app process? The change I'm making right now to make the reactQuery command work independently is to have the QueryClientProvider injected in the App.tsx file by a utility rather than be part of the boilerplate, similar to what we did for hooks.

stevehanson commented 8 months ago

@codeofdiego yes, as part of createApp is what I was referring to 👍 Sorry for the poorly jotted note.

stevehanson commented 6 months ago

I rebased this PR and updated it per the Trello ticket we defined this morning:

Add Tanstack React Query to all new apps for now, as opposed to this being opt-in. Down the line once we support a GraphQL client, we will give users the choice
For simplicity, don't allow running this command individually for existing apps. Will just support adding it to new apps for now

New apps currently pull down coffee drinks from an API and display them. We might want to consider a different API and maybe showing results in a separate tab in a follow-up PR.

📸 Screenshot

Note: the bottom tab display issues that can be seen below will be fixed in #44.

stevehanson commented 6 months ago

Released in 0.6.1.