search

thoughtbot / bitters

Add a dash of pre-defined style to your Bourbon.
https://thoughtbot.com
MIT License
1.39k stars 142 forks source link

Instructions on Github do not mention `bitters install` should be in stylesheets directory #116

Closed dpwildboar closed 9 years ago

dpwildboar commented 9 years ago

after installing bourbon and neat i added gem 'bitters' to the Gemfile and then did:

bundle install bitters install

and found the resulting base/ in the rails project home where the Gemfile is.

should this not be installed either in app/assets/stylesheets/ or vendor/assets/stylesheets/?

also, i found it unclear what is being said in part 5 of the install instructions... are you saying that we should add what is mentioned after "And import Neat after Bitters:" to _base.scss or app/assets/stylesheets/application.css.scss (i am expecting this is the correct one)?

this is with: osx 10.10 rvm 1.25.33 Rails 4.1.6 ruby 2.1.3p242 (2014-09-19 revision 47630) [x86_64-darwin14.0]

joshuaogle commented 9 years ago

Hi @dpwildboar. Yes, you should install it in your stylesheets directory, not in the root.

The Bitters website (http://bitters.bourbon.io/) does a good job of explaining this, but it looks like the README on Github skips the step of switching to the stylesheets directory.

Renaming this issue so we can address it better.

joshuaogle commented 9 years ago

Just realized I missed the second part of your question, sorry about that.

The instructions in part 5 just mean that your applicationcss.scss should start like so:

@import "bourbon";
@import "base/base";
@import "neat";

// All other imports

Just to make sure that it happens in the right order

dpwildboar commented 9 years ago

then my suggestion would be that it explicitly states that, since it starts talking out about _base.scss and assumes that the reader will note the change in context to application.css.scss with out stating so.

thanks for following up so quickly. =)