search

thoughtbot / bitters

Add a dash of pre-defined style to your Bourbon.
https://thoughtbot.com
MIT License
1.39k stars 142 forks source link

Flash alerts not displaying #120

Closed jackturnbull closed 9 years ago

jackturnbull commented 9 years ago

Having only just seen 5aa232c32f2ce51465302c92bd066b9219d407f9, this may now be irrelevant but I'll post it anyway in case others have been having the same.

All other elements within bitters seem to be loading fine and I've tried creating pre and blockquote elements just to check that I'm not going mad. Whatever I do, I'm unable to get alerts working the way I expect. Installation of Bourbon/Neat/Bitters was fine so I don't think this is an installation issue.

I've uploaded a project with this issue to https://github.com/jackturnbull/phdb in case that saves you chasing a ghost.

tysongach commented 9 years ago

How are you compiling your Sass? Are there any errors being thrown during compilation?

Keep in mind that the Flashes and Errors in Bitters use placeholder selectors, so by default, nothing will you output. You have to extend them yourself, where needed. Unless I missed it, I didn’t see anywhere in your code that you’re doing so.

jackturnbull commented 9 years ago

Well, I feel like a bit of an idiot right now. Completely went over my head that they used placeholders since the pre and blockquotes worked of the box. Thanks again for the feedback and the work on Bitters.

tysongach commented 9 years ago

@jackturnbull No worries! Happy to help.