search

thoughtbot / bitters

Add a dash of pre-defined style to your Bourbon.
https://thoughtbot.com
MIT License
1.39k stars 142 forks source link

$base-spacing output changes relative to font-size of current selector #135

Closed hatzipanis closed 9 years ago

hatzipanis commented 9 years ago

I may be utilising it wrong but shouldn't the output of $base-spacing remain relative to the base font size of the project (font-size on body) and not the font-size of the current selector? Therefore wouldn't rem be a better option here? 

$base-spacing: $base-line-height * 1rem;

Obviously no IE8 support.

tysongach commented 9 years ago

It depends, but I tend use em’s for this, and I don’t think there is a right or wrong way, here. But Bitters is meant to be changed to fit your needs, so feel free to swap em for rem in your project.