Closed jjmulenex closed 8 years ago
This is intended. line-height
does not require a unit (and it is generally preferred to not have one).
interesting when setting em as a value type there is a huge difference in display. So when using refills with the article snippets and dropping the the "em" the trailing carrot drops below the base line. [image: Screen Shot 2016-02-16 at 3.48.29 PM.png] I can load the site so you can see the problem across your products, which I love btw.
thanks Jeremy
On Tue, Feb 16, 2016 at 3:36 PM Will H McMahan notifications@github.com wrote:
This is intended. line-height does not require a unit (and it is generally preferred to not have one).
— Reply to this email directly or view it on GitHub https://github.com/thoughtbot/bitters/issues/221#issuecomment-184883685.
after reading: https://css-tricks.com/almanac/properties/l/line-height/ I see what you were intending. I guess the override is refills needs to be more specific.
thanks again. jeremy
On Tue, Feb 16, 2016 at 3:50 PM Jeremy Mulenex jeremy@aboutjm.com wrote:
interesting when setting em as a value type there is a huge difference in display. So when using refills with the article snippets and dropping the the "em" the trailing carrot drops below the base line. [image: Screen Shot 2016-02-16 at 3.48.29 PM.png] I can load the site so you can see the problem across your products, which I love btw.
thanks Jeremy
On Tue, Feb 16, 2016 at 3:36 PM Will H McMahan notifications@github.com wrote:
This is intended. line-height does not require a unit (and it is generally preferred to not have one).
— Reply to this email directly or view it on GitHub https://github.com/thoughtbot/bitters/issues/221#issuecomment-184883685 .
@poedenon I don’t think your screenshot made it to GitHub, can you re-post so we have a better sense of the issue?
If Refills is using a unit in line-height
values, that’s a bug and we should probably remove those.
Here is the screenshot
@jjmulenex Yep, it also looks like the "Read More >" is display: inline-block
and not just display: inline
. You may have better luck just trying display: inline
on the link. Alternatively you can mess with vertical-align: baseline
which should be helpful… probably.
seems resolved. reopen if issue is continued
So the processed css is missing the "em" for the default processed bitters scss
example:
I have attached the css generated. app copy.css.txt
Thanks Jeremy