thoughtbot / bitters

Add a dash of pre-defined style to your Bourbon.
https://thoughtbot.com
MIT License
1.39k stars 142 forks source link

0.10.0 introduced a backwards-incompatible change to the import path #69

Closed jedfoster closed 10 years ago

jedfoster commented 10 years ago

A minor quibble: I've got some code that relies on the old bitters/bitters install path and @import signature.

I don't quite understand why a minor point release would change something as basic as the install path, nor why it would change to something as generic as base/base. Easy enough to work around, but for my 2¢, @import 'bitters/bitters' is far more descriptive than @import 'base/base'. I'd like to see a return to the previous install path.

kylefiedler commented 10 years ago

I don't quite understand why a minor point release would change something as basic as the install path

I think your title explains the reason for a minor point release, because it might break some existing code bases that rely on Bitters.

We prefer it to be base because it better describes intent of the code within and to make the project structure more clear. When looking at the stylesheets directory, bitters means nothing to people unfamiliar with the library. Many of the thoughtbot designers were changing the name of the folder for handoff, my preference is that each project for us is consistent with the naming.

You are more than welcome to rename the folder and file once you have installed bitters.