thoughtbot / bourbon

A Lightweight Sass Tool Set
https://www.bourbon.io/
MIT License
9.09k stars 878 forks source link

Issue with font-family in sass/scss #910

Closed iandstanley closed 8 years ago

iandstanley commented 8 years ago

I have been trying to use the font-family: $helvetica in my sass and keep getting the same error

Regenerating: 1 file(s) changed at 2016-07-06 16:08:29 Conversion error: Jekyll::Converters::Scss encountered an error while converting '/css/main.scss': Undefined variable: "$helvetica". on line 7 ...error: Error: Undefined variable: "$helvetica". on line 7 Error: Run jekyll build --trace for more information.

This goes back to the source code:

h1
  font-family: $helvetica

main.scss contains

@import "plugins/bourbon/bourbon";
@import "plugins/base/base";
@import "plugins/neat-settings.scss";
@import "plugins/neat/neat";

neat-settings.scss does not override any of the base settings and just contains visual grid settings

$visual-grid: true;
$visual-grid-color: #faa;
$visual-grid-index: front;
$visual-grid-opacity: 0.2 !default;
$visual-grid-breakpoints: () !default;

Running the latest beta of bourbon installed fresh last week and checked for updates before posting this

$ bourbon -v Bourbon 5.0.0.beta.6

Neat appears to function properly. As does using Refils for the footer/header

Any ideas?

tysongach commented 8 years ago

@iandstanley $helvetica was renamed to $font-stack-helvetica in Bourbon 5.

tysongach commented 8 years ago

@iandstanley Are you still having issues?

iandstanley commented 8 years ago

Nope.

Similar problem exists with the docs for each of the font stacks.

I was going to sort out a patch to the docs but after running bundle install from the cloned repo it took out my working copy of Jekyll preventing me from continuing with my current design work. Fixing that took me a day of repeatedly uninstalling and installing Ruby and Gems till I was sick of it.

I'll maybe look at creating a patch later between work when I have the time to create a virtual machine and a clean install to work from.

tysongach commented 8 years ago

@iandstanley Sorry to hear about your troubles. Couple notes: