search

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps
https://thoughtbot.com/open-source
MIT License
1.97k stars 428 forks source link

Dependency on Capybara 2.13.x #1023

Closed stratigos closed 6 years ago

stratigos commented 7 years ago

I would like to keep using capybara-webkit, and also use the latest minor release for capybara.

capybara is now at 2.15.1. capybara-webkit is dependent on 2.13.x : 

Bundler could not find compatible versions for gem "capybara":
  In Gemfile:
    capybara (~> 2.15.1)

    capybara-webkit (~> 1.14.0) was resolved to 1.14.0, which depends on
      capybara (< 2.14.0, >= 2.3.0)

Is there a way I can leverage something > 2.14.0, or plans for a new release to update to the latest capybara minor version? Thanks!

mikegee commented 7 years ago

I think https://github.com/thoughtbot/capybara-webkit/pull/1000 resolves this for you, but there hasn't been another release since then.

andy4thehuynh commented 6 years ago

1000 doesn't have instructions how to install. Still having issues with this.

stratigos commented 6 years ago

Thanks @mikegee, glad to know theres lots of traction on it.

twalpole commented 6 years ago

You can use the current master branch with the latest Capybara

bmulholland commented 6 years ago

@twalpole Am I reading correctly that the fix was merged in May? When will a new version be released?

twalpole commented 6 years ago

@bmulholland No clue - I don't do the releases - just code commits -- use the master branch if you want the newest stuff.

bmulholland commented 6 years ago

@twalpole I've tried master and am hitting crashes of Capybara Webkit. Sadly it doesn't seem like there's a viable way to use latest Capybara without migrating off this project.

twalpole commented 6 years ago

@bmulholland Thats one option. A better option would be to report the crashes with reproducible test cases, help get them fixed, and thereby help the whole community.

bmulholland commented 6 years ago

@twalpole That's a good idea. I won't have time to do a reproducible test case before the holidays - would a crash log on its own be useful?

We do need to upgrade Capybara in the next few days - is there a stable commit I can use as a temporary measure?

twalpole commented 6 years ago

@bmulholland There is no specific stable commit, master tries to be stable at all times, and is currently passing all tests - https://travis-ci.org/thoughtbot/capybara-webkit. As for a crash log, it MAY give a clue, but a reproducible example will provide much more info and get fixed MUCH quicker.