Only override font in Qt versions where it's needed

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps

https://thoughtbot.com/open-source

MIT License

1.97k stars 427 forks source link

Only override font in Qt versions where it's needed #1035

Closed twalpole closed 6 years ago

twalpole commented 6 years ago

This fix was only needed for Qt < 5. It has caused issues for users with custom fonts when using characters which have no matching codepoint in the Arial font. This PR only applies the font override to versions of Qt where needed. As mentioned in Issue #1006 the number of users still on Qt < 5 should be relatively small, and it makes no sense to penalize users on Qt >= 5

dezmathio commented 6 years ago

yay! :+1: thanks @twalpole

mhoran commented 6 years ago

We'd just planned to remove this outright in the 2.0.0 milestone, but I suppose this works as well.