search

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps
https://thoughtbot.com/open-source
MIT License
1.97k stars 428 forks source link

Node#[] should prefer properties over attributes #1037

Closed twalpole closed 6 years ago

twalpole commented 6 years ago

This changes Node#[] to match the behavior of other drivers in preferring properties over attributes. It also changes the Node command to JSON encode the return so we can differentiate between boolean responses and strings. Fixes issue #914

twalpole commented 6 years ago

@jferris @mhoran What was the Node#attached? method for? It doesn't appear to be used/tested anywhere in the code

mhoran commented 6 years ago

I believe this is a relic of backwards compatibility with Capybara.

On Wed, Nov 08, 2017 at 05:57:38PM +0000, Thomas Walpole wrote:

@jferris @mhoran What was the Node#attached? method for? It doesn't appear to be used/tested anywhere in the code

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/thoughtbot/capybara-webkit/pull/1037#issuecomment-342901212

-- Matt Horan matt@matthoran.com http://matthoran.com/

twalpole commented 6 years ago

@mhoran Ok, PR #1039 deprecates it - unless you think it is safe to just remove.

twalpole commented 6 years ago

@jferris Suggestions applied - will merge once tests pass