Add support for keys and offset with mouse clicks coming in Capybara 3

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps

https://thoughtbot.com/open-source

MIT License

1.97k stars 428 forks source link

Add support for keys and offset with mouse clicks coming in Capybara 3 #1050

Closed twalpole closed 6 years ago

twalpole commented 6 years ago

This adds support for passing key modifiers and offset x,y coordinates to be set when calling Node#click/right_click/double_click coming in Capybara 3

jferris commented 6 years ago

It looks like there weren't any tests added for this change. Since Capybara 3 isn't actually out yet, maybe that makes sense right now, but I assume we want test coverage before merging.

twalpole commented 6 years ago

@jferris Test coverage is in the Capybara specs in the master (v3) branch - which is currently an allowed failure in the travis matrix.