search

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps
https://thoughtbot.com/open-source
MIT License
1.97k stars 428 forks source link

Target macOS minimum version 10.9 #1073

Closed emilyst closed 5 years ago

emilyst commented 5 years ago

By targeting macOS 10.9 minimum, we are able to build again using Xcode

  1. This avoids the use of a build configuration that was deprecated since Xcode 8 and obsoleted in Xcode 10.

See https://developer.apple.com/documentation/xcode_release_notes/xcode_10_release_notes#3035632.

Fixes #1071 and #1072.

igbanam commented 5 years ago

How do we get this merged? I'm looking to welcome this change like 🤗

emilyst commented 5 years ago

How do we get this merged? I'm looking to welcome this change like 🤗

I have the suspicion that this project is abandoned.

jferris commented 5 years ago

Has anybody else had a chance to try this out? It would be good to hear how this change affects people on other versions of macOS and Xcode. If we can get a few confirmations that this fixes the issue without breaking older builds, I will merge this.

emilyst commented 5 years ago

Not that it gets you a lot of mileage coming from me—I'd also like to hear from others—but I tried this on both High Sierra and Mojave, where it worked fine. I'll wait to hear if this breaks for anyone.

jferris commented 5 years ago

@emilyst Did you happen to also try it out on Xcode 9?

emilyst commented 5 years ago

@emilyst Did you happen to also try it out on Xcode 9?

I don't recall, unfortunately, so we'll count that as a no.

emilyst commented 5 years ago

Let me see if I can get a coworker to try this out today if they're still running High Sierra with Xcode 9.4.1.

ColinTheRobot commented 5 years ago

Just ran this change on high sierra 10.13.6 (17G65) / X Code 9.4.1 and it appears to be working on my end

emilyst commented 5 years ago

Just ran this change on high sierra 10.13.6 (17G65) and it appears to be working on my end

With which version of Xcode?

ColinTheRobot commented 5 years ago

Just edited: 9.4.1

pvdb commented 5 years ago

Just ran this change on High Sierra 10.13.6 (17G65) but - unlike @ColinTheRobot - I am on Xcode Version 10.0 (10A255) and it appears to be working on my end as well!!! Thanks for the fix @emilyst

3wille commented 5 years ago

Works for me on OSX 10.13.4 (17E199) and Xcode 9.4.1 (9F2000).

jferris commented 5 years ago

Thanks @emilyst and everybody who tried this out.

I've merged this into master as aecaa45e2f34642f3a23ce68f32e7cec8be762c3. Master contains a number of other unreleased changes, so in order to ensure this is fixed without breaking anything else, I've released 1.15.1 with only this change to RubyGems.

emilyst commented 5 years ago

Incredible. I appreciate your looking at this. Notify me if this causes a problem and I'll see if there's something that can be done.

bernespinoza commented 5 years ago

thanks @emilyst

dinkengraven commented 5 years ago

Thank you, @emilyst!

tomily1 commented 5 years ago

Thank you, @emilyst