thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps
https://thoughtbot.com/open-source
MIT License
1.97k stars 428 forks source link

Adding console output for Teaspoon #905

Open jejacks0n opened 8 years ago

jejacks0n commented 8 years ago

Teaspoon is a javascript test runner, and it supports using capybara-webkit as the driver. The capybara-webkit support was added via a PR, and a few people added some additional information that console output wasn't working correctly in an issue.

I dug into the implementation and attempted to add better support for capybara-webkit, but it doesn't behave exactly as expected. If someone here is interested in helping clarify how we can accomplish this it would be great.

You can read more about the issue here: https://github.com/modeset/teaspoon/issues/428#issuecomment-209090525

Check the initial implementation here: https://github.com/modeset/teaspoon/blob/master/lib/teaspoon/driver/capybara_webkit.rb

Check my adjusted implementation here: https://github.com/modeset/teaspoon/blob/capybara-webkit-fixes/lib/teaspoon/driver/capybara_webkit.rb

If there's a better way to get the output that's great. I can provide any additional details as needed.

twalpole commented 6 years ago

Is this still an issue ?