Build the webkit server executable in parallel

thoughtbot / capybara-webkit

A Capybara driver for headless WebKit to test JavaScript web apps

https://thoughtbot.com/open-source

MIT License

1.97k stars 428 forks source link

Build the webkit server executable in parallel #990

Closed joankaradimov closed 6 years ago

joankaradimov commented 7 years ago

During the gem installation there is a message that says "Building native extensions. This could take a while...". And it takes a while.

This PR should make it take a bit less for people with more cores and Ruby 2+.

twalpole commented 6 years ago

Does this work on Windows? https://ruby-doc.org/stdlib-2.4.2/libdoc/etc/rdoc/Etc.html#method-c-nprocessors .

joankaradimov commented 6 years ago

My current environment is based on JRuby on Windows. But it appears to be working on all rubies I have lying around. Here are the ones I can test on [in format flavour - version (RUBY_PLATFORM)]:

MRI - 2.4 (x64-mingw32)
MRI - 2.3 (x86_64-msys)
JRuby - 9.1.6.0 (java)
JRuby - master (java)

twalpole commented 6 years ago

Ok - good enough -- thanks