Use prefix to make ident unique by OAuth2 provider

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments

MIT License

499 stars 30 forks source link

Use prefix to make ident unique by OAuth2 provider #124

Closed jferris closed 9 years ago

jferris commented 9 years ago

We want to replace Upcase with GitHub for authentication. We need a prefix before identifiers to ensure there are no collisions between Upcase and GitHub users.

pbrisbin commented 9 years ago

LGTM -- I'm surprised you didn't have to update any tests. I guess we don't construct users in them.

jferris commented 9 years ago

I'm surprised you didn't have to update any tests. I guess we don't construct users in them.

Whoops, looks like I do. I forgot yesod devel doesn't run them. Fixing those now.

pbrisbin commented 9 years ago

Good to merge on Green.