Closed pbrisbin closed 9 years ago
Remove tests for unused-Handlers They've never been used and only increase maintenance burden. In my next PR, I'll remove the Handlers themselves (and any code they use).
I'd recommend removing those handlers and their tests in a separate pull request on master and then rebasing this on top of the branch for that pull request.
I'd recommend removing those handlers and their tests in a separate pull request on master
FYI: #151
Build is failing due to this: https://github.com/mietek/halcyon/issues/36
On it.
https://github.com/mietek/halcyon/issues/36 should now be fixed. The fix is now tested and merged to master
.
Please try again, keeping in mind if you’ve disabled Halcyon self-updates, you’ll need to re-enable them, or update Halcyon manually.
@jferris rebased, green build, ready for a final look.
Oh, and thanks for the quick fix @mietek !
Looks good to merge.
This removes the need for Helpers.Assertions
This (the rename and function move) gets us closer to the default scaffold.
This replaces Helpers.DB. All functions live in DB for composability and functions used by only one Example were moved to be directly with it.
This will soon become a PR to upstream
They've never been used and only increase maintenance burden. In my next PR, I'll remove the Handlers themselves (and any code they use).
It is only used there.