thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

Dummy login doesn't work in development #154

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

The Dummy login builds a Creds with the "dummy" credsPlugin and no credsExtra. This doesn't work in development because we require a name/email (provided by GitHub) to be present in the credsExtra. This does work in test because we create a user ahead of time. Existing users aren't found in development because they have the "github" plugin. So the auth flow tries to create them new with the "dummy" plugin and fails because name/email is not present.

We should detect a "dummy" login within getAuthId and do something to make it work again.

Optionally, we should add some logging around this area is it's been difficult to debug why a login doesn't work.

pbrisbin commented 9 years ago

Fixed as part of #161