search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

Working demo page #159

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

152 adds such a page, but Carnival does not work as-is there. The elements are positioned incorrectly.

We need to change how things are done in either JS or CSS (or both) so that elements are positioned correctly in this simple layout (article > p, article > pre) without breaking the install on robots.thoughtbot.com (and ideally without adding a slew of site-specific options).

Once working, add a link to it on the Homepage.

pbrisbin commented 9 years ago

Maybe this page could double as the general marketing page?

jferris commented 9 years ago

I like the idea of using the marketing page as the demo page - just let people comment on the public pages of the site.

I'm guessing we'll have to monitor/prune the comments occasionally.

pbrisbin commented 9 years ago

Closing.

163 fixes the bugs and #167 captures the need to "demo" by having comments on Carnival itself.