thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

Update to latest scaffold #161

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Benefits:

Notes:

The process went like this:

I reformatted some code (Application.hs, TestImport.hs) to match the scaffold even though it was already functionally the same. This made this update and should make future updates easier.

I made it so that lists (exports, imports, dependencies, extensions, etc) match the scaffold exactly, then a blank line, then anything additional we need (alphabetized). There were only a few places where it didn't make sense to follow this exactly (e.g. TestImport's import Test.Hspec), but I did attempt to keep a vimdiff against the scaffold as readable as possible. This and the scaffold's use of stylish-haskell means that this code-base doesn't match our style guide completely -- I think that's OK.

jferris commented 9 years ago

Nice, it will be good to work with the latest Yesod stuff, especially classy-prelude. The settings changes are interesting, too.

pbrisbin commented 9 years ago

@jferris any more thoughts before I merge this and try it on staging?

(I'll also wait for Travis)

jferris commented 9 years ago

No, this looks good to me.

mietek commented 9 years ago

FYI — you should be able to use HALCYON_IGNORE_ALL_CONSTRAINTS instead of having to remove constraints files.