thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments

MIT License

499 stars 30 forks source link

Initial Design Work #162

Closed smharley closed 9 years ago

smharley commented 9 years ago

Some initial mid-fidelity mockups landing - home

site index - first site

add new site

site index - with sites

edit site

jferris commented 9 years ago

Nice! I like the logo.

This is pretty straightforward, and I think it's just what we need.

A few notes:

We removed most of the site fields. I think it's just "name," "url," and "language" now.
Pat had the idea of allowing comments on the Carnival site itself, so the site also serves as the demo. Not sure if there's a way to work this into the design, but I liked the idea.
I'm guessing most users will have exactly one site, so we may want to optimize for that. Might not be worth doing any changes for MVP, but I think it will make the experience slicker for most users.

pbrisbin commented 9 years ago

Yeah, I think this looks great!

My own thoughts:

Keeping the new-site and site-index on the same page is convenient technically. Maybe now that there are fewer fields, we can keep that aspect?
For the demo, we just need a copy-heavy page. So if Tour or Docs shapes up that way, we could ditch Demo and just self-install on that page

smharley commented 9 years ago

@pbrisbin what do you think about using a modal for the new site?

re: Demo, that sounds good! those links are mostly placeholder to get a sense of what the nav could be

smharley commented 9 years ago

I also assumed 1 site, but it was kind of a guess more than anything. I'll keep that in mind

pbrisbin commented 9 years ago

what do you think about using a modal for the new site?

No problem with me. Is there any down-side?

smharley commented 9 years ago

not that i can think of. it would keep them on the same page, but without any clutter. downsides might come up if there end up being a lot of fields (not great for modals)

pbrisbin commented 9 years ago

Cool, I don't envision a lot of fields any time soon -- we're at 3 now.

pbrisbin commented 9 years ago

I've created separate Issues for each page that still requires styling (i.e. it still uses bootstrap). Feel free to move the mocks to the appropriate issue or just use the back-reference to see them from there.

220 #223 #224 #225

smharley commented 9 years ago

:+1: sounds good, i'll be working on this tomorrow!