search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

findUserComments should sort by CreatedAt #164

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Whoops...

jferris commented 9 years ago

But it compiled!!!

Should we have any tests for this change?

pbrisbin commented 9 years ago

This is very strange. In trying to add a test, I'm finding that I can't make it fail.

runDB $ selectList [] []

Seems to naturally sort by Created.

pbrisbin commented 9 years ago

And yet, this is returning comments out of order: https://carnival-staging.herokuapp.com/sites/2/comments?article=announcing-maintaining-open-source-projects-book

pbrisbin commented 9 years ago

I'm done figuring this out, it has to be something about my Postgres setup. I'm just going to add the test even though I can't make it fail.

pbrisbin commented 9 years ago

@jferris is this OK to merge?