search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

WIP: Ensure Settings.StaticFiles is always compiled #178

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Pulled over from #176 -- see there for the problem. This branch should pass because nothing was added to /static here, but this did not fix this issue.

pbrisbin commented 9 years ago

Spoke with Halcyon maintainer -- the reason this didn't work is that the source-dir ($2) is not the correct directory within which to touch, I should use build-dir ($3). This should work in that Settings.StaticFiles will be re-compiled on every build, but it's a bit over-aggressive. We should only need to do it when static/* is changed. He's offered to add a new hook that will allow us to better decided if we need to perform the touch.

pbrisbin commented 9 years ago

Going to commit that change directly in pb-docs, as we won't know that it worked without an actual source change to static/*.