search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Other authentication methods #196

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago
pbrisbin commented 9 years ago

Adding Twitter to yesod-auth-oauth2: https://github.com/thoughtbot/yesod-auth-oauth2/pull/27

pbrisbin commented 9 years ago

Adding Google to carnival: https://github.com/thoughtbot/carnival/pull/212

pbrisbin commented 9 years ago

I'm going to consider this done for now. We won't be adding Twitter since it doesn't provide an Email. If folks feels strongly about providing FB, we can add a new issue for it.

jferris commented 9 years ago

It's too bad Twitter is such a pain. I feel like that's the most likely one people will use. Is there a way to get people to "finalize" OAuth2 logins, so that they enter an email after authenticating with Twitter?

Or, could we make email nullable? Is that a bad path to go down?

pbrisbin commented 9 years ago

We could probably add a custom screen to get an email from the user as part of on-boarding. I'm not sure what this'd look like or how difficult it'd be. I'd definitely prefer not to make userEmail a Maybe, but it's not the end of the world if the other options are too complicated. As of now, that would really just mean handling gravatars and notifications differently.