thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
499 stars 30 forks source link

Take advantage of AuthenticationResult #205

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Reasoning:

Using AuthenticationResult and returning useful ServerError values, should help debugging. Splitting out the credsExtra parsing this way will making adding new plugins (that return different credsExtra maps) easier. Supporting the dummy plugin via dummyProfile makes it possible to write plugin-agnostic examples in the test and only test plugin-specific behavior in the GitHub (and eventually Google, Twitter, etc) contexts.

JoelQ commented 9 years ago

LGTM :+1:

pbrisbin commented 9 years ago

Addressed all comments, rebased, will merge on Green. Thanks!