thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Improvements to authentication spec #208

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Another change pulled out of a branch where I'm adding Google authentication.

The Show/Eq instances allow assertions against AuthenticationResult values which replace generic pattern match failures with something useful. The extracted assertions are reused when testing Google logins. Once Profile was exported for the assertions, it made sense to also export dummyProfile to remove that data duplication.

jferris commented 9 years ago

This looks good to me.