Add GoogleEmail2 authentication

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments

MIT License

501 stars 30 forks source link

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

TODO:

pbrisbin commented 9 years ago

Ping @smharley for the design work on Login/Homepage

jferris commented 9 years ago

This looks good from a development perspective.

pbrisbin commented 9 years ago

Thoughts on merging this as-is?

Keep the Homepage and Embed going direct to GitHub
The only difference would be if someone ends up on /auth/login directly, there will be a Google option there
Follow up separately with design work and change it so users go to login and not directly to GitHub

jferris commented 9 years ago

That sounds like a good plan to me.