Style login page #220 - Githubissues

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments

MIT License

501 stars 30 forks source link

Style login page #220 #230

Closed smharley closed 9 years ago

smharley commented 9 years ago

Change sign in link to point to /auth/login
Make language consistent: Sign in/Sign out

pbrisbin commented 9 years ago

This looks great.

There are two other Sign in links: the Homepage and the Embed template. Do you want to change those here too, or follow up separately? I don't mind either way.

donokuda commented 9 years ago

Markup looks good to me. :+1:

EDIT: And design (just to clarify) :wink:

smharley commented 9 years ago

I'll change the links, and get them in here

smharley commented 9 years ago

@pbrisbin can I get a review of the new links?

pbrisbin commented 9 years ago

LGTM