Add options to remove presumptive DOM changes

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments

MIT License

501 stars 30 forks source link

Add options to remove presumptive DOM changes #234

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Document new force_relative and shift_article options
Make forcing position:relative conditional on option
Make automatic shifting of article conditional on option

Resolve #184

jferris commented 9 years ago

I feel like introducing this now may be premature. We don't have anybody else using the site yet, so we're not sure what people will actually want or need. I'd prefer to defer adding this functionality until we have an example of where it's needed.

pbrisbin commented 9 years ago

I guess I didn't really look at it as functionality. Just putting an option around functionality we already have. I'll close the PR but save the branch in case we decide we want this at some point.