search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Allow comments of any (non-zero) length #245

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

I'm not sure the messaging is needed once we allow comments of any non-zero length. It's pretty obvious when submitting an empty comment does nothing, I was originally confused while trying to add non-empty comments and it wasn't doing anything because it was less than 4 characters (think: "+1").

That said, I added the messaging before realizing this and it's here now, so wanted to get others' opinions before discarding it. Also, if there is a good reason to keep the 4-character validation, I'll want the messaging again.

pbrisbin commented 9 years ago

/cc @cpytel

jferris commented 9 years ago

I think the client-side validation is probably worth having. I can't comment on the 4 character requirement.

pbrisbin commented 9 years ago

@cpytel what was the reasoning for the 4 character minimum?