search

thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Follow conventions in JavaScript casing #247

Closed jferris closed 6 years ago

jferris commented 9 years ago

We're currently using underscored attributes (article_author), but it's more common in JavaScript to use camel case (articleAuthor).

We could look for both, but suggest camel case in the documentation.

pbrisbin commented 9 years ago

Is this just for passing options into Carnival.init, or also the API requests/resposes?

jferris commented 9 years ago

I think the things we intentionally expose to the user (Carnival.init) are most important.