thoughtbot / carnival

An unobtrusive, developer-friendly way to add comments
MIT License
501 stars 30 forks source link

Does not work in Firefox #248

Closed pbrisbin closed 9 years ago

pbrisbin commented 9 years ago

Steps:

InvalidAccessError: A parameter or an operation is not supported by the underlying object

Based this: http://stackoverflow.com/questions/16677893/evil-firefox-error-a-parameter-or-an-operation-is-not-supported-by-the-under, it's because of the async: false on the call for user information (see #170). One solution may be here: http://stackoverflow.com/questions/16668386/cors-synchronous-requests-not-working-in-firefox

pbrisbin commented 9 years ago

Reopening, the fix was not a fix and breaks other browsers. We need to instead fix #170 to get things working in Firefox.

jferris commented 9 years ago

This seems to be working in Firefox now. I think this was fixed by #170.